Skip to content

Generated module conversion step - explicitify #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Generated module conversion step - explicitify #4

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented May 18, 2022 •
edited
Loading

This step makes all implicit namespace accesses explicit, e.g. "Node" turns into "ts.Node".

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify (this PR)
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from c518af7 to 420bf65 Compare May 18, 2022 00:01
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 91e8c22 to 8885adb Compare May 18, 2022 00:02
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 420bf65 to 3648c44 Compare May 18, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 8885adb to 0e1d400 Compare May 18, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 3648c44 to a830489 Compare May 19, 2022 01:31
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 0e1d400 to d0b989b Compare May 19, 2022 01:31
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from a830489 to 72e33b9 Compare May 25, 2022 01:21
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from d0b989b to 1ab00db Compare May 25, 2022 01:21
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 72e33b9 to 31d12ad Compare May 25, 2022 02:40
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 1ab00db to 6a10437 Compare May 25, 2022 02:40
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 31d12ad to c4ee091 Compare May 25, 2022 21:05
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 6a10437 to 65d3c7d Compare May 25, 2022 21:06
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from c4ee091 to d8e7812 Compare May 25, 2022 21:09
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 65d3c7d to 998d77a Compare May 25, 2022 21:09
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from d8e7812 to 0eb75ad Compare May 25, 2022 21:10
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 998d77a to c9d5bf0 Compare May 25, 2022 21:10
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 0eb75ad to a92d585 Compare May 25, 2022 21:43
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from c9d5bf0 to 13ef966 Compare May 25, 2022 21:43
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from a92d585 to 20a1274 Compare May 25, 2022 21:45
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 13ef966 to aed7990 Compare May 25, 2022 21:45
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 20a1274 to bc5f2cf Compare May 26, 2022 03:15
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from aed7990 to 1a405d2 Compare May 26, 2022 03:15
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from bc5f2cf to 340cb2c Compare May 26, 2022 21:56
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 1a405d2 to f154eb7 Compare May 26, 2022 21:56
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 340cb2c to a765a69 Compare May 27, 2022 04:15
@jakebailey jakebailey changed the title CONVERSION STEP - stripNamespaces [3/8] CONVERSION STEP - stripNamespaces May 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from f154eb7 to 6cf63ac Compare May 27, 2022 04:15
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from a765a69 to 68c89d8 Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [3/8] CONVERSION STEP - stripNamespaces [4/8] CONVERSION STEP - stripNamespaces May 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 6cf63ac to 89d1af6 Compare May 27, 2022 04:16
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from f9b7af8 to ec84a52 Compare October 25, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 6a98718 to 23c7eee Compare October 27, 2022 04:18
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from ec84a52 to 2ac68f9 Compare October 27, 2022 04:18
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 23c7eee to f98b049 Compare October 27, 2022 17:31
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 2ac68f9 to d12318c Compare October 27, 2022 17:31
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from f98b049 to 7ce18fa Compare October 27, 2022 17:36
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from d12318c to 5e3513d Compare October 27, 2022 17:36
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 7ce18fa to e804a13 Compare October 28, 2022 02:18
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 5e3513d to 77a2601 Compare October 28, 2022 02:18
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from e804a13 to a67847a Compare October 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 77a2601 to 408dd2a Compare October 31, 2022 21:29
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from a67847a to 65a391d Compare November 2, 2022 00:39
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 408dd2a to 999d5e8 Compare November 2, 2022 00:39
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 65a391d to bfc0a00 Compare November 2, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 999d5e8 to f7c6d49 Compare November 2, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from bfc0a00 to 6798fd4 Compare November 2, 2022 19:41
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from f7c6d49 to 5c6d677 Compare November 2, 2022 19:41
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 6798fd4 to 81ff1b4 Compare November 6, 2022 21:51
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 5c6d677 to 41e599e Compare November 6, 2022 21:51
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 81ff1b4 to 6b4080a Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch 2 times, most recently from 52d5cfc to c890e6f Compare November 7, 2022 03:52
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from fb39d27 to 1de6c28 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from c890e6f to 7310192 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 1de6c28 to f533e5f Compare November 7, 2022 21:37
@jakebailey
Generated module conversion step - explicitify
dc25bdf 
This step makes all implicit namespace accesses explicit, e.g. "Node" turns into "ts.Node".
@jakebailey jakebailey force-pushed the transform-stack-commit-4 branch from 7310192 to dc25bdf Compare November 7, 2022 21:37
@jakebailey jakebailey deleted the branch transform-stack-commit-3 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-4 branch November 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey